From 541466f790bc7b606f5497bad72dd048174490b8 Mon Sep 17 00:00:00 2001 From: "kfraser@localhost.localdomain" Date: Fri, 29 Sep 2006 11:17:29 +0100 Subject: [PATCH] [BLKTAP] Remove unnecessary TLB flush from blktap driver. blktap_poll is calling tlb_flush_all() in its main ring buffer polling loop. This seems to be superfluous: the hypervisor should be performing any necessary tlb flushes on grant table operations performed by the back-end. Even a simple memory barrier is unnecessary here as the RING_PUSH_REQUESTS() call performs a wmb() anyway. And tlb_flush_all() is not exported to modules, so this call prevents blktap from building as a module. Just remove it. Signed-off-by: Stephen Tweedie --- linux-2.6-xen-sparse/drivers/xen/blktap/blktap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/linux-2.6-xen-sparse/drivers/xen/blktap/blktap.c b/linux-2.6-xen-sparse/drivers/xen/blktap/blktap.c index 41d7bc66af..bfd8dfb432 100644 --- a/linux-2.6-xen-sparse/drivers/xen/blktap/blktap.c +++ b/linux-2.6-xen-sparse/drivers/xen/blktap/blktap.c @@ -692,7 +692,6 @@ static unsigned int blktap_poll(struct file *filp, poll_table *wait) poll_wait(filp, &info->wait, wait); if (info->ufe_ring.req_prod_pvt != info->ufe_ring.sring->req_prod) { - flush_tlb_all(); RING_PUSH_REQUESTS(&info->ufe_ring); return POLLIN | POLLRDNORM; } -- 2.30.2